Add support for signaling an external process via pid file #118
Conversation
|
Hi @kfox1111 Thanks for the submission. The linter is complaining about |
pkg/sidecar/sidecar.go
Outdated
| @@ -153,6 +155,22 @@ func (s *Sidecar) updateCertificates(svidResponse *workloadapi.X509Context) { | |||
| // signalProcess sends the configured Renew signal to the process running the proxy | |||
| // to reload itself so that the proxy uses the new SVID | |||
| func (s *Sidecar) signalProcess() (err error) { | |||
| if s.config.PidFileName != "" { | |||
| atomic.StoreInt32(&s.processRunning, 1) | |||
There was a problem hiding this comment.
why 1 is required inside processRunning?
it looks like it is to avoid if that is set bellow,
if that is the case I think we msut avoid this in order to simply the code and add this if as part of the switch, and run a signal there...
There was a problem hiding this comment.
Yeah. Really wasn't sure how to redo that switch, when honestly I wasn't exactly sure how it was working to begin with. Setting it to 1 let it fall through to the right path.
How should this be reworked?
There was a problem hiding this comment.
I took a stab at reworking it.
pkg/sidecar/sidecar.go
Outdated
| err = cmd.Start() | ||
| if err != nil { | ||
| return fmt.Errorf("error executing process: %v\n%w", s.config.Cmd, err) | ||
| if s.config.Cmd != "" { |
There was a problem hiding this comment.
Move inside case nil
|
Checking back in on this functionality. How do we get it moving again? |
@kfox1111 Sorry for letting this slip.
|
faisal-memon
force-pushed
the
pidfile
branch
from
e689b7f
to
cbe340b
Compare
Signed-off-by: Kevin Fox <[email protected]>
faisal-memon
force-pushed
the
pidfile
branch
from
cbe340b
to
8742213
Compare
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Partially implements: #115